Skip to content

Fix the missing parentheses when calling is_torchao_available in quantization_config.py. #10961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix the missing parentheses when calling is_torchao_available in quantization_config.py. #10961

merged 1 commit into from
Mar 4, 2025

Conversation

@CyberVy
Copy link
Contributor

@CyberVy CyberVy commented Mar 4, 2025 •
edited
Loading

Missing parentheses when calling is_torchao_available() will result in an import error in systems without torchao.

@CyberVy CyberVy changed the title Fixed the missing parentheses when calling is_torchao_available in quantization_config.py. Fix the missing parentheses when calling is_torchao_available in quantization_config.py. Mar 4, 2025
@CyberVy
Copy link
Contributor Author

CyberVy commented Mar 4, 2025

@asomoza
Could you have a look? Thanks!

a-r-r-o-w
a-r-r-o-w approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is my bad! I should've tested with/without TorchAO in #10927 but only did with TorchAO and missed this.

cc @DN6 Are the lazy imports not lazy? 😅

@asomoza
Copy link
Member

asomoza commented Mar 4, 2025

Thanks!

@asomoza asomoza merged commit dcd77ce into huggingface:main Mar 4, 2025
4 checks passed
@CyberVy CyberVy deleted the quantization_config_check_torchao_available branch March 4, 2025 12:53
@a120092009
Copy link
Contributor

Thank you for fixing the code! I just noticed this issue. @CyberVy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asomoza asomoza asomoza approved these changes

+1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CyberVy @asomoza @a120092009 @a-r-r-o-w